Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MC-38993: Magento\Authorization\Model\ResourceModel\Rules missing update method #30947

Merged
merged 3 commits into from
Nov 28, 2020
Merged

MC-38993: Magento\Authorization\Model\ResourceModel\Rules missing update method #30947

merged 3 commits into from
Nov 28, 2020

Conversation

engcom-Golf
Copy link
Contributor

Added deprecated tag to the method. Will be deleted in next major release

Description (*)

Method was never implemented and used. Migrated from Magento 1

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento\Authorization\Model\ResourceModel\Rules missing update method #29128

Manual testing scenarios (*)

  1. Create a module that will use method \Magento\Authorization\Model\Rules::update
  2. Run the code
    Expected result:
    An exception that the method is obsolete but not a fatal error
  3. Run Static Tests
    Expected result:
    An exception that method can not be used as it is deprecated

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 17, 2020

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 17, 2020
@engcom-Golf engcom-Golf self-assigned this Nov 17, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Nov 17, 2020
@engcom-Golf
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@engcom-Golf can it be covered with automated test?

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Progress: needs update labels Nov 17, 2020
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Nov 17, 2020
@engcom-Golf
Copy link
Contributor Author

@ihor-sviziev these changes don't add any functionality that can be broken and nothing to cover with tests. If you use the deprecated method in code somewhere Static Tests will fail.

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8473 has been created to process this Pull Request

@engcom-Golf
Copy link
Contributor Author

@magento run Functional Tests B2B, Integration Tests

@engcom-Golf
Copy link
Contributor Author

@magento run all tests

@zakdma
Copy link
Contributor

zakdma commented Nov 23, 2020

@magento copy pr to https://github.com/magento-tsg/magento2ce

@zakdma
Copy link
Contributor

zakdma commented Nov 23, 2020

@magento import pull request to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the pull request successfully imported.

@engcom-Bravo
Copy link
Contributor

QA not applicable, dev experience is required to test the PR. Moved to Extended Testing column

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Nov 23, 2020
@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Testing in Progress in High Priority Pull Requests Dashboard Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 23, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Nov 23, 2020
@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 23, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit 57f5832 into magento:2.4-develop Nov 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2020

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Recently Merged in High Priority Pull Requests Dashboard Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@zakdma zakdma zakdma approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@zakdma zakdma

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Authorization Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: extended testing Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magento\Authorization\Model\ResourceModel\Rules missing update method
6 participants
@engcom-Golf @ihor-sviziev @magento-engcom-team @zakdma @engcom-Bravo @engcom-Foxtrot